Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: param validation for all RPC methods #29

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

andreabadesso
Copy link
Collaborator

@andreabadesso andreabadesso commented Jan 15, 2025

Acceptance Criteria

  • We should include parameter validation for all RPC methods
  • If a rpc request fails validation, the handler should throw a specific error

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso added the enhancement New feature or request label Jan 15, 2025
@andreabadesso andreabadesso self-assigned this Jan 15, 2025
@andreabadesso andreabadesso changed the title feat: added validation for createToken and sendNanoContractTx feat: param validation for all RPC methods Jan 20, 2025
@andreabadesso andreabadesso requested review from luislhl and removed request for tuliomir January 23, 2025 12:41
@andreabadesso andreabadesso force-pushed the feat/parameter-validation branch from a6f68cf to 5fcf239 Compare January 29, 2025 16:19
@andreabadesso andreabadesso requested a review from luislhl January 30, 2025 13:18
@andreabadesso andreabadesso requested review from r4mmer and removed request for pedroferreira1 January 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review (Done)
Development

Successfully merging this pull request may close these issues.

2 participants