feat: send tokens #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
changed the base branch from
master
to
feat/parameter-validation
andreabadesso
force-pushed
the
feat/send-tokens
branch
from
34535b3 to
464124a
Compare
raul-oliveira
approved these changes
Feb 26, 2025
| const sendTransaction = await wallet.sendManyOutputsSendTransaction(sendTransactionOutputs, { | ||
| inputs: params.inputs || [], | ||
| changeAddress: params.changeAddress, | ||
| pinCode: '111111', |
There was a problem hiding this comment.
Magic string here. Assign a variable that holds the meaning of it.
IE stubPinCode or dumbPinCode
andreabadesso
force-pushed
the
feat/send-tokens
branch
from
4cdf462 to
1d56a1b
Compare
| network: z.string().min(1), | ||
| outputs: z.array(z.object({ | ||
| address: z.string().optional(), | ||
| value: z.string().transform(val => BigInt(val)), |
There was a problem hiding this comment.
Isn't it optional when it's a data output?
There was a problem hiding this comment.
It is, changed it to optional and added a better refine method to make it required only when not data output
Comment on lines
95
to
98
| if (typedOutput.type === 'data') { | ||
| (typedOutput as unknown as { value: bigint }).value = BigInt(1); | ||
| typedOutput.token = '00'; | ||
| } |
There was a problem hiding this comment.
Do you need this? I think the lib method already handles it in case of a data output
There was a problem hiding this comment.
We actually do need it because prepareTxData doesn't add the 1 HTR to data outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
sendTransactionRPC request properlyChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged