feat: reown #713

andreabadesso · 2024-12-26T14:55:14Z

Screen.Recording.2025-01-02.at.10.39.57.mov

Acceptance Criteria

We should support reown connections, including adding new ones and managing existing
We should support all nano contract operations, including CreateNanoContractTx and SignOracleData
The wallet-desktop production build should be protected with LavaMoat

Security Checklist

Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

…ed by walletKit

andreabadesso · 2025-01-02T14:12:08Z

src/components/TxData.js

@@ -898,7 +898,7 @@ class TxData extends React.Component {
            <label>Type:</label> {upperFirst(action.type)}
          </div>
          <div>
-            <label>Amount:</label> {numberUtils.prettyValue(action.amount, this.props.decimalPlaces)} {this.getSymbol(action.token_uid)}
+            <label>Amount:</label> {numberUtils.prettyValue(typeof action.amount === 'bigint' ? action.amount : BigInt(action.amount), this.props.decimalPlaces)} {this.getSymbol(action.token)}


This was crashing

Fixed by #715

src/components/Reown/NanoContractActions.js

src/components/Reown/ReownModal.js

src/components/Reown/modals/CreateTokenModal.js

tuliomir · 2025-01-22T19:23:24Z

src/components/Reown/modals/SendNanoContractTxModal.js

+                        {typeof value === 'string' && value.length > 20 
+                          ? helpers.truncateText(value, 8, 4)
+                          : typeof value === 'bigint'
+                            ? value.toString()
+                            : value.toString()}


suggestion(non-blocking): It seems our linter did not complain about the use of nested ternaries here, so it's not a necessary change.

But it's worth avoiding, if possible.

Fixed! Thanks

tuliomir · 2025-01-22T20:13:38Z

src/reducers/reown.js

thought(non-blocking): We already have @reduxjs/toolkit@v2 in this repository. It enables us to write reducers using Immer ( reference ) and slices ( reference ).

This is a migration we can do at any pace, but since this section of the reducers seem simple enough, we could make our pilot implementation here.

I think this PR is large enough as it is, let's do it in a later PR

tuliomir · 2025-01-22T20:15:30Z

src/sagas/modal.js

+ * @param {Object} action.payload.modalProps - The props to pass to the modal
+ */
+function* showModal({ payload: { modalType, modalProps } }) {
+  if (modalContext) {


suggestion(non-blocking): Add an error message if the modalContext was not provided, allowing for easier debugging.

Done! Thanks

tuliomir · 2025-01-22T20:21:01Z

src/screens/ReownConnect.js

+  const connectionFailed = useSelector(state => state.reown.connectionFailed);
+  const sessions = useSelector(state => state.reown.sessions || {});


suggestion(non-blocking): Retrieve all data from store in a single fetch.

Suggested change

const connectionFailed = useSelector(state => state.reown.connectionFailed);

const sessions = useSelector(state => state.reown.sessions || {});

const { connectionFailed, sessions } = useSelector(state => ({

connectionFailed: state.reown.connectionFailed,

sessions: state.reown.sessions || {},

}));

Done! Thanks

src/store/index.js

tuliomir · 2025-01-22T21:05:03Z

src/sagas/reown.js

+  });
+
+export function* onSignMessageRequest({ payload }) {
+  const { accept, deny: denyCb, data, dapp } = payload;


question(non-blocking): Why not name the variable acceptCb to match denyCb?

Done, thanks

tuliomir

None of the remaining open comments are blocking, so this code is approved.

feat: added reown components, packages and modal

d863661

andreabadesso requested a review from pedroferreira1 as a code owner December 26, 2024 14:55

andreabadesso self-assigned this Dec 26, 2024

andreabadesso added the enhancement New feature or request label Dec 26, 2024

andreabadesso added 7 commits December 27, 2024 12:05

chore: stop using null-loader for pino

db57974

chore: added lavamoat policy for walletconnect deps

ef7e3af

chore: updated walletconnect deps

f419d6d

refactor: global reown module

e0d100c

chore: better sourcemaps by providing full webpack path

4fa8a38

chore: normalize walletconnect packages to include eventClient requir…

e001ee2

…ed by walletKit

feat: modals implementation

ae0e5be

andreabadesso force-pushed the feat/reown branch from b93d567 to 64134bd Compare January 2, 2025 13:53

andreabadesso requested a review from r4mmer January 2, 2025 13:59

andreabadesso commented Jan 2, 2025

View reviewed changes

andreabadesso requested review from tuliomir and removed request for r4mmer January 2, 2025 16:37

andreabadesso added 14 commits January 6, 2025 10:04

fix: using bigint on txData screen

a65f58a

fix: using bigint on nano contract detail screen

3a44194

feat: modals implementation

6152bef

refactor: each modal on its own component

ddb6833

feat: network changed -> clear reown sessions

582c6a0

refactor: cosmetic changes to reown

288c0f3

refactor: using separate methods for each nc action

6d14d1f

refactor: removed pointless logs

02fe6ea

feat: listen for feature toggle update

1300e43

refactor: added hathor header

729c707

refactor: removed unused helper method

4eb067f

chore: added comment explaining serialization check

399585a

fix: added missing action types

f9fe19b

fix: moved reown feature toggle

1c55f54

andreabadesso added 6 commits January 6, 2025 10:04

refactor: correct docstrings in reown module

f862034

feat: added missing handlers

4d8170d

refactor: removed useless delay

f961ee3

refactor: improved debug log

6b626c6

chore: fixed walletkit version

a4617c5

chore: updated lavamoat policy with new fixed versions

265efae

andreabadesso force-pushed the feat/reown branch from ba4fca2 to 265efae Compare January 6, 2025 13:05

tuliomir reviewed Jan 22, 2025

View reviewed changes

andreabadesso added 2 commits January 24, 2025 17:14

refactor: use constants

978e729

docs: added a TODO on create token modal

afa90fe

tuliomir approved these changes Jan 24, 2025

View reviewed changes

andreabadesso added 4 commits January 29, 2025 09:32

refactor: removed ternary in jsx

69004f6

refactor: error when modalContext is unavailable

055fa48

refactor: single selector for multiple states

d7146a1

refactor: accept -> acceptCb

13dbe5b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: reown #713

feat: reown #713

andreabadesso commented Dec 26, 2024 •

edited

Loading

andreabadesso Jan 2, 2025

tuliomir Jan 22, 2025

tuliomir Jan 22, 2025

andreabadesso Jan 29, 2025

tuliomir Jan 22, 2025

andreabadesso Jan 29, 2025

tuliomir Jan 22, 2025

andreabadesso Jan 29, 2025

tuliomir Jan 22, 2025

andreabadesso Jan 29, 2025

tuliomir Jan 22, 2025

andreabadesso Jan 30, 2025

tuliomir left a comment

		const connectionFailed = useSelector(state => state.reown.connectionFailed);
		const sessions = useSelector(state => state.reown.sessions \|\| {});

-  const connectionFailed = useSelector(state => state.reown.connectionFailed);
-  const sessions = useSelector(state => state.reown.sessions || {});
+  const { connectionFailed, sessions } = useSelector(state => ({
+    connectionFailed: state.reown.connectionFailed,
+    sessions: state.reown.sessions || {},
+    }));

feat: reown #713

Are you sure you want to change the base?

feat: reown #713

Conversation

andreabadesso commented Dec 26, 2024 • edited Loading

Acceptance Criteria

Security Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tuliomir left a comment

Choose a reason for hiding this comment

andreabadesso commented Dec 26, 2024 •

edited

Loading