Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add a new flag
-D hl_w_null_compare
which will gives a warning where we have done null comparison instead of implicitly convert to 0. It can help existing hl code check theirs comparison before moving to the newer version. Related commits:This code works correctly during the build, however, when running inside VSCode and open the file from the "PROBLEMS" section after build, the warning disappear after a small delay (probably some rebuild on the specific file happens). It does not impact all files, at least not std files.
@kLabz du you have any idea on how to prevent the warning been removed?