Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local statics vs display requests #11849

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Dec 2, 2024

No description provided.

@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Dec 2, 2024
@Simn
Copy link
Member

Simn commented Dec 3, 2024

While we're here we should test that it's reported as a local variable, not a field.

@kLabz
Copy link
Contributor Author

kLabz commented Dec 9, 2024

This is weird.. that test works locally Oo

@kLabz kLabz force-pushed the display_vs_local_statics branch 2 times, most recently from 20e090b to e95b87c Compare December 9, 2024 11:13
@kLabz kLabz force-pushed the display_vs_local_statics branch from e95b87c to 98f90c1 Compare December 9, 2024 11:24
@kLabz kLabz merged commit 2ecf485 into development Dec 9, 2024
99 checks passed
kLabz added a commit that referenced this pull request Dec 10, 2024
* Local statics cannot be found in class decls

* Add test

* Update test

* Fix test for CI
@kLabz kLabz deleted the display_vs_local_statics branch January 21, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants