haxe.Serializer cleanup #11864
Merged
haxe.Serializer cleanup #11864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
commented
Dec 10, 2024
std/haxe/Serializer.hx
Outdated
| @@ -379,8 +379,6 @@ class Serializer { | |||
| } | |||
| #end | |||
| case TClass(c): | |||
| if (useCache) | |||
| cache.pop(); | |||
There was a problem hiding this comment.
I don't know if I'm missing some really intricate detail here or if this is really just silly. Nothing seems to happen between this pop and the push operations below that could access the cache, so I don't see why this was here.
Simn
commented
Dec 10, 2024
Surely this is better than working with straight up Dynamic...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make that file look a bit less like a warzone.
I don't really know how robust our tests are but I'm sure it's gonna be fine.