-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET Standard #51
.NET Standard #51
Conversation
…le projected changed to .net core
…rence core project
❌ Build HdrHistogram.NET 1.20.0-koomuqfb failed (commit a960190ed5 by @alhardy) |
❌ Build HdrHistogram.NET 1.20.0-vrhmmlkx failed (commit f40e362d72 by @alhardy) |
❌ Build HdrHistogram.NET 1.20.0-mitbstyt failed (commit 82c554c568 by @alhardy) |
❌ Build HdrHistogram.NET 1.20.0-ptwbfvvp failed (commit c1d970643d by @alhardy) |
|
Nice work @alhardy. Can we squish the commits. i.e.
So it seems that there are 2 legitimate commits of the 7 in the PR. I can pick up this work and lean heavily on your good work if you are not up for it. I will also need to change the AppVeyor builds as you have moved the build scripts, so this currently wont even build. |
@LeeCampbell yeah the appveyor build's broken due to the build changes I've made. I won't get a chance to make those changes for a couple of weeks, I've added you as a collaborator to my fork if you're happy to pick up the requested changes beforehand. |
@LeeCampbell the tooling has changed so much you would be better off burning this PR to the ground and doing it again. Happy to 1:1 and run you through how RxUI now does xtargeting/nuget creation. See ReactiveUI/ReactiveUI repo if you prefer self-service. |
PR for #17