Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Standard #51

Closed
wants to merge 10 commits into from
Closed

.NET Standard #51

wants to merge 10 commits into from

Conversation

alhardy
Copy link

@alhardy alhardy commented Jan 28, 2017

PR for #17

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@alhardy
Copy link
Author

alhardy commented Jan 28, 2017

nuget.exe removed here 7cfe633

and added to gitignore here 3f85777

@AppVeyorBot
Copy link

@alhardy
Copy link
Author

alhardy commented Jan 28, 2017

default.ps1 is more of a psake convention, there is a build.cmd in the solution root which calls out to that.

@LeeCampbell
Copy link
Collaborator

Nice work @alhardy.
A few things need to get fixed before this gets merged.

Can we squish the commits. i.e.

  • seems no point having the nuget.exe committed to the repo, then removed in the same PR.
  • I would rather the build scripts not know about AppVeyor, and have their SemVer passed in as an argument
  • merge commits instead of rebase

So it seems that there are 2 legitimate commits of the 7 in the PR. I can pick up this work and lean heavily on your good work if you are not up for it.

I will also need to change the AppVeyor builds as you have moved the build scripts, so this currently wont even build.

@alhardy
Copy link
Author

alhardy commented Jan 31, 2017

@LeeCampbell yeah the appveyor build's broken due to the build changes I've made.

I won't get a chance to make those changes for a couple of weeks, I've added you as a collaborator to my fork if you're happy to pick up the requested changes beforehand.

@ghuntley
Copy link

ghuntley commented May 26, 2017

@LeeCampbell the tooling has changed so much you would be better off burning this PR to the ground and doing it again. Happy to 1:1 and run you through how RxUI now does xtargeting/nuget creation. See ReactiveUI/ReactiveUI repo if you prefer self-service.

@LeeCampbell
Copy link
Collaborator

Thanks @alhardy finally closed by #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants