feat: show minions top bar before and during hero picking #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KelvinCS
commented
Oct 26, 2023
•
KelvinCS
commented
- I have read the Contributing Guidelines
- I have already signed the CLA
KelvinCS
force-pushed
the
feat/show-bgs-top-bar-on-hero-picking
branch
from
f111401 to
34acb14
Compare
azeier
requested changes
Oct 26, 2023
There was a problem hiding this comment.
There is a small bug here when queuing into multiple games in a row:
- In the first game everything works as expected, minion list is visible during hero picking, BobsBuddy panel is not. Play one combat to have the BobsBuddy panel fully appear, concede.
- In the second game the BobsBuddy panel is now also visible during hero picking.
There is probably some behavior missing to hide the BobsBuddy panel specifically that was not necessary previously, since the entire top section was only visible after hero picking.
KelvinCS
force-pushed
the
feat/show-bgs-top-bar-on-hero-picking
branch
from
ab42dc9 to
7712c9d
Compare
Fixed by other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.