Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current insured people in list #1885

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Show current insured people in list #1885

merged 5 commits into from
Nov 23, 2023

Conversation

hugokallstrom
Copy link
Contributor

Screenshot_20231121_094042

@hugokallstrom hugokallstrom requested a review from a team as a code owner November 21, 2023 08:40
StylianosGakis
StylianosGakis requested changes Nov 22, 2023
View reviewed changes
Copy link
Member

@StylianosGakis StylianosGakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see if the allowEdit is the right thing to do here.
Also see if we can edit the UiState the presenter provides to make it impossible for it to represent some of the states which should be impossible to reach.

...re-edit-coinsured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/data/CoInsured.kt Outdated Show resolved Hide resolved
...re-edit-coinsured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/data/CoInsured.kt Outdated Show resolved Hide resolved
...ured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/EditCoInsuredDestination.kt Outdated Show resolved Hide resolved
...ure-edit-coinsured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/InsuredRow.kt Show resolved Hide resolved
...main/kotlin/com/hedvig/android/feature/editcoinsured/navigation/EditCoInsuredDestinations.kt Show resolved Hide resolved
...ure-edit-coinsured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/InsuredRow.kt Outdated Show resolved Hide resolved
...nsured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/EditCoInsuredPresenter.kt Show resolved Hide resolved
...ured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/EditCoInsuredDestination.kt Outdated Show resolved Hide resolved
...ured/src/main/kotlin/com/hedvig/android/feature/editcoinsured/ui/EditCoInsuredDestination.kt Outdated Show resolved Hide resolved
Base automatically changed from feature/edit-co-insured-presenter to feature/edit-co-insured-module November 23, 2023 08:58
Base automatically changed from feature/edit-co-insured-module to feature/edit-co-insured November 23, 2023 08:58
@hugokallstrom hugokallstrom merged commit 618f30b into feature/edit-co-insured Nov 23, 2023
4 checks passed
@hugokallstrom hugokallstrom deleted the feature/edit-co-insured-list branch November 23, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StylianosGakis StylianosGakis StylianosGakis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugokallstrom @StylianosGakis