Feature/45 to 60 upgrade #2349
Merged
Feature/45 to 60 upgrade #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StylianosGakis
approved these changes
Dec 12, 2024
...in/com/hedvig/android/feature/addon/purchase/ui/customize/CustomizeTravelAddonDestination.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+172
to
+178
| } // without + (supposedly with minus) | ||
| else { | ||
| stringResource( | ||
| R.string.TERMINATION_FLOW_PAYMENT_PER_MONTH, // todo: mb better to have a separate key? | ||
| uiState.totalPriceChange.amount.toInt(), | ||
| ) | ||
| } |
There was a problem hiding this comment.
So it's without minus now, but we do want a minus to exist here I suppose? Help me understand a bit here
There was a problem hiding this comment.
well it is difference between two numbers, so if we (what if) have a price going down - it should be negative?
There was a problem hiding this comment.
Can we ask the others too? Perhaps we should not show anything here in those scenarios instead, not sure
.../main/kotlin/com/hedvig/android/feature/addon/purchase/ui/summary/AddonSummaryDestination.kt
Outdated
Show resolved
Hide resolved
.../main/kotlin/com/hedvig/android/feature/addon/purchase/ui/summary/AddonSummaryDestination.kt
Show resolved
Hide resolved
# Conflicts: # app/feature/feature-addon-purchase/src/main/kotlin/com/hedvig/android/feature/addon/purchase/ui/customize/CustomizeTravelAddonDestination.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.