Fix: Excluded addons should stay shrinked and non-interactive #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix/excluded-addons-should-stay-shrinked
panasetskaya
approved these changes
Jan 23, 2025
Always have 16.dp above the underDetailsContent, and ensure that there is 8.dp space between the bottom button and the optional above button. Avoid using the default impl in the non excluded case as that one has the top padding hardcoded
Base automatically changed from
fix/scaffold-without-insets-clipping
to
develop
January 23, 2025 16:13
Now properly animates the height shrinking in those scenarios Context: https://hedviginsurance.slack.com/archives/C03HT2JRDPG/p1737630319718449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hedviginsurance.slack.com/archives/C07MM6F0DK2/p1737638802028819?thread_ts=1737038997.141969&cid=C07MM6F0DK2
This also has #2388 merged since it contains a fix for the padding of the button in there