Integrated protractor-http-mock. #39
Conversation
| var mock = require('protractor-http-mock'); | ||
| mock.config = { | ||
| rootDirectory: __dirname, // default value: process.cwd() | ||
| protractorConfig: 'protractor.conf.js' |
There was a problem hiding this comment.
What does this line do? Because for browserstack tests, the protractor config file will be protractor.browserstack.conf.js. Could not adapting this maybe cause weird bugs at a later point?
|
The aim of this line is to specify in which protractor file the http-mock configuration is. It also works for browserstack, since the http-mock configuration is independent of the usage of browserstack or not. |
It is. But I have to think of a way that does not involve promises. |
|
The server is necessary to run the HTML and JavaScript files in the Browser - maybe this part of the name should also be improved: "Set up the HTTP server"? |
|
Oh, yeah, I’m sorry. I’m so tired that I don’t even understand my own code. |
Good idea. |
|
I made some comments on this in #40 – sorry! |
|
I think |
Yes, but the real tests are not introduced in this pull request. In #40 most of the tests in |
|
lgtm |
Integrated protractor-http-mock.
No description provided.