Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flake variables #20

Open
wants to merge 10 commits into
base: flake.accum
Choose a base branch
from

Conversation

AnilKumar-NOAA
Copy link

@AnilKumar-NOAA AnilKumar-NOAA commented Jan 27, 2023

We have four commits in the io/FV3GFS_io.F90 and one commit in ccpp/data/GFS_typedefs.F90 file
We added flake sections with many flake schemes options instead of just one scheme
Further, I also added flake variables in the three commits recently in FV3GFS_io.F90 file.

io/FV3GFS_io.F90 Outdated Show resolved Hide resolved
io/FV3GFS_io.F90 Outdated Show resolved Hide resolved
io/FV3GFS_io.F90 Outdated Show resolved Hide resolved
Copy link
Owner

@HelinWei-NOAA HelinWei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation for the change in this commit?

@AnilKumar-NOAA
Copy link
Author

The motivation is to provide clear variables for lake model. We have done small commits piece by piece and test the code.
I have finished fv3GFS_io.F90 and other related files are updated with flake code against baseline.
Next, will go ccpp physics and work way through to implement flake code.
Will create another pull request for ccpp physics now.
Let me know

@HelinWei-NOAA
Copy link
Owner

@AnilKumar-NOAA lake_model_option is not given an initial value. Also the configuration for RT needs to be modified to include this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants