Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Another attempt at fixing this weird issue #156

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JuanPedroGHM
Copy link
Member

An attempt at #152

  • Changed monitoring subprocess to spawn instead of fork to have a clearer separation between main and subprocess resources.
  • Explicit delete and close of backends on subprocess, to avoid dangling file descriptors from the rapl backend.
  • More logging.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 54.81481% with 61 lines in your changes missing coverage. Please review.

Project coverage is 62.67%. Comparing base (0a04ca0) to head (70ce6ae).

Files with missing lines Patch % Lines
perun/monitoring/subprocess.py 4.87% 39 Missing ⚠️
perun/monitoring/monitor.py 75.71% 17 Missing ⚠️
perun/backend/nvml.py 20.00% 4 Missing ⚠️
perun/backend/rocmsmi.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   63.13%   62.67%   -0.46%     
==========================================
  Files          31       32       +1     
  Lines        2517     2575      +58     
==========================================
+ Hits         1589     1614      +25     
- Misses        928      961      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuanPedroGHM
Copy link
Member Author

This, did not work.
Next attempt:

  • Only one subprocesses, for all the rounds. Should remove some overhead, might be more stable. Need to write logic for a reusable subprocesses.

@JuanPedroGHM JuanPedroGHM self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant