Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #782

Open
wants to merge 4 commits into
base: next-major-release
Choose a base branch
from
Open

Refactor #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
969925f
refactor
Sep 2, 2021
b45cd31
Merge branch 'next-major-release' into Refactor
jawwadmukhtargmail Sep 2, 2021
b476056
add Desktop tag
Sep 2, 2021
d814a01
Merge branch 'Refactor' of https://github.com/HelpMyStreet/front-end …
Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion HelpMyStreetFE.Specs/HelpMyStreetFE.Specs/Default.srprofile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</Steps>
</DeploymentTransformation>

<Targets>
<Targets>
<Target name="Edge">
<DeploymentTransformationSteps>
<EnvironmentVariable variable="Test_Browser" value="Edge" />
Expand All @@ -49,5 +49,19 @@
<EnvironmentVariable variable="Test_Browser" value="Safari" />
</DeploymentTransformationSteps>
</Target>

<Target name="Android">
<Filter>!tagmatch:Desktop</Filter>
<DeploymentTransformationSteps>
<EnvironmentVariable variable="Test_Browser" value="Android" />
</DeploymentTransformationSteps>
</Target>

<Target name="IOS">
<Filter>!tagmatch:Desktop</Filter>
<DeploymentTransformationSteps>
<EnvironmentVariable variable="Test_Browser" value="IOS" />
</DeploymentTransformationSteps>
</Target>
</Targets>
</TestProfile>
213 changes: 146 additions & 67 deletions HelpMyStreetFE.Specs/HelpMyStreetFE.Specs/Drivers/BrowserSeleniumDriverFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,65 @@
using OpenQA.Selenium.Remote;
using OpenQA.Selenium.Safari;
using System;
using System.Collections.Generic;
using System.Reflection;
using System.Text;
using TechTalk.SpecFlow;

namespace HelpMyStreetFE.Specs.Drivers
{
struct BrowserDetails
{
private FeatureContext _featureContext;
private ScenarioContext _scenarioContext;
private Version _version;
public BrowserDetails(FeatureContext featureContext, ScenarioContext scenarioContext, Version version)
{
_featureContext = featureContext;
_scenarioContext = scenarioContext;
_version = version;
}

public string BrowserVersion { get { return "latest"; } }
public string Resolution { get { return "1920x1080";} }
public string Project { get { return "HelpMyStreetFE"; } }
public string BrowserStackUser { get { return Environment.GetEnvironmentVariable("BROWSERSTACK_USERNAME"); } }
public string BrowserStackAccessKey { get { return Environment.GetEnvironmentVariable("BROWSERSTACK_ACCESS_KEY"); } }
public bool Debug { get { return true; } }
public string Console { get { return "info"; } }
public string NetworkLogs { get { return "true"; } }
public string Name { get { return _featureContext.FeatureInfo.Title + " / " + _scenarioContext.ScenarioInfo.Title; } }
public string Build { get { return $"Version {_version} on {Environment.MachineName}"; } }
}

struct Windows
{
public string OSVersion { get { return "10"; }}
public string OS { get { return "Windows"; } }
}

struct MacOS
{
public string OSVersion { get { return "Big Sur"; } }
public string OS { get { return "OS X"; } }
}

public class BrowserSeleniumDriverFactory
{
private readonly FeatureContext _featureContext;
private readonly ScenarioContext _scenarioContext;

private Version _version;
private BrowserDetails _browserDetails;
private Windows _windows;
private MacOS _macOS;
private const string URI = "https://hub-cloud.browserstack.com/wd/hub/";

public BrowserSeleniumDriverFactory(FeatureContext featureContext, ScenarioContext scenarioContext)
{
_featureContext = featureContext;
_scenarioContext = scenarioContext;
_version = Assembly.GetExecutingAssembly().GetName().Version;
_browserDetails = new BrowserDetails(_featureContext, _scenarioContext,_version);
_windows = new Windows();
_macOS = new MacOS();
}

public IWebDriver GetForBrowser(string browserId)
Expand All @@ -33,103 +75,140 @@ public IWebDriver GetForBrowser(string browserId)
case "CHROME": return GetChromeDriver();
case "FIREFOX": return GetFirefoxDriver();
case "SAFARI": return GetSafariDriver();
case "ANDROID": return GetAndroidDriver();
case "IOS": return GetIOSDriver();
case string browser: throw new NotSupportedException($"{browser} is not a supported browser");
default: throw new NotSupportedException("not supported browser: <null>");
}
}


private IWebDriver GetFirefoxDriver()
{
Version version = Assembly.GetExecutingAssembly().GetName().Version;

FirefoxOptions firefoxCapability = new FirefoxOptions();
firefoxCapability.AddAdditionalCapability("os_version", "10", true);
firefoxCapability.AddAdditionalCapability("browser", "firefox", true);
firefoxCapability.AddAdditionalCapability("browser_version", "latest", true);
firefoxCapability.AddAdditionalCapability("os", "Windows", true);
firefoxCapability.AddAdditionalCapability("resolution", "1920x1080", true);
firefoxCapability.AddAdditionalCapability("project", "HelpMyStreetFE", true);
firefoxCapability.AddAdditionalCapability("name", _featureContext.FeatureInfo.Title + " / " + _scenarioContext.ScenarioInfo.Title, true); // test name
firefoxCapability.AddAdditionalCapability("build", $"Version {version} on {System.Environment.MachineName}", true); // Your tests will be organized within this build
firefoxCapability.AddAdditionalCapability("browserstack.user", Environment.GetEnvironmentVariable("BROWSERSTACK_USERNAME"), true);
firefoxCapability.AddAdditionalCapability("browserstack.key", Environment.GetEnvironmentVariable("BROWSERSTACK_ACCESS_KEY"), true);
firefoxCapability.AddAdditionalCapability("browserstack.debug", true, true);
firefoxCapability.AddAdditionalCapability("browserstack.console", "info", true);
firefoxCapability.AddAdditionalCapability("browserstack.networkLogs", "true", true);

IWebDriver driver = new RemoteWebDriver(new Uri("https://hub-cloud.browserstack.com/wd/hub/"), firefoxCapability);
firefoxCapability.AddAdditionalCapability("os_version", _windows.OSVersion, true);
firefoxCapability.AddAdditionalCapability("browser_version", _browserDetails.BrowserVersion, true);
firefoxCapability.AddAdditionalCapability("os", _windows.OS, true);
firefoxCapability.AddAdditionalCapability("resolution", _browserDetails.Resolution, true);
firefoxCapability.AddAdditionalCapability("project", _browserDetails.Project, true);
firefoxCapability.AddAdditionalCapability("name", _browserDetails.Name, true); // test name
firefoxCapability.AddAdditionalCapability("build", _browserDetails.Build, true); // Your tests will be organized within this build
firefoxCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser, true);
firefoxCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey, true);
firefoxCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug, true);
firefoxCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console, true);
firefoxCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs, true);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), firefoxCapability);

return driver;
}

private IWebDriver GetChromeDriver()
{
Version version = Assembly.GetExecutingAssembly().GetName().Version;

ChromeOptions chromeCapability = new ChromeOptions();
chromeCapability.AddAdditionalCapability("os_version", "10", true);
chromeCapability.AddAdditionalCapability("browser", "Chrome", true);
chromeCapability.AddAdditionalCapability("browser_version", "latest", true);
chromeCapability.AddAdditionalCapability("os", "Windows", true);
chromeCapability.AddAdditionalCapability("resolution", "1920x1080", true);
chromeCapability.AddAdditionalCapability("project", "HelpMyStreetFE", true);
chromeCapability.AddAdditionalCapability("name", _featureContext.FeatureInfo.Title + " / " + _scenarioContext.ScenarioInfo.Title, true);
chromeCapability.AddAdditionalCapability("build", $"Version {version} on {System.Environment.MachineName}", true);
chromeCapability.AddAdditionalCapability("browserstack.user", Environment.GetEnvironmentVariable("BROWSERSTACK_USERNAME"), true);
chromeCapability.AddAdditionalCapability("browserstack.key", Environment.GetEnvironmentVariable("BROWSERSTACK_ACCESS_KEY"), true);
chromeCapability.AddAdditionalCapability("browserstack.debug", true, true);
chromeCapability.AddAdditionalCapability("browserstack.console", "info", true);
chromeCapability.AddAdditionalCapability("browserstack.networkLogs", "true", true);

IWebDriver driver = new RemoteWebDriver(new Uri("https://hub-cloud.browserstack.com/wd/hub/"), chromeCapability);
chromeCapability.AddAdditionalCapability("os_version", _windows.OSVersion, true);
chromeCapability.AddAdditionalCapability("browser_version", _browserDetails.BrowserVersion, true);
chromeCapability.AddAdditionalCapability("os", _windows.OS, true);
chromeCapability.AddAdditionalCapability("resolution", _browserDetails.Resolution, true);
chromeCapability.AddAdditionalCapability("project", _browserDetails.Project, true);
chromeCapability.AddAdditionalCapability("name", _browserDetails.Name, true);
chromeCapability.AddAdditionalCapability("build", _browserDetails.Build, true);
chromeCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser, true);
chromeCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey, true);
chromeCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug, true);
chromeCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console, true);
chromeCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs, true);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), chromeCapability);

return driver;
}

private IWebDriver GetEdgeDriver()
{
Version version = Assembly.GetExecutingAssembly().GetName().Version;

EdgeOptions edgeCapability = new EdgeOptions();
edgeCapability.AddAdditionalCapability("os_version", "10");
edgeCapability.AddAdditionalCapability("browser", "Edge");
edgeCapability.AddAdditionalCapability("browser_version", "latest");
edgeCapability.AddAdditionalCapability("os", "Windows");
edgeCapability.AddAdditionalCapability("resolution", "1920x1080");
edgeCapability.AddAdditionalCapability("project", "HelpMyStreetFE");
edgeCapability.AddAdditionalCapability("name", _featureContext.FeatureInfo.Title + " / " + _scenarioContext.ScenarioInfo.Title);
edgeCapability.AddAdditionalCapability("build", $"Version {version} on {System.Environment.MachineName}");
edgeCapability.AddAdditionalCapability("browserstack.user", Environment.GetEnvironmentVariable("BROWSERSTACK_USERNAME"));
edgeCapability.AddAdditionalCapability("browserstack.key", Environment.GetEnvironmentVariable("BROWSERSTACK_ACCESS_KEY"));
edgeCapability.AddAdditionalCapability("browserstack.debug", true);
edgeCapability.AddAdditionalCapability("browserstack.console", "info");
edgeCapability.AddAdditionalCapability("browserstack.networkLogs", "true");

IWebDriver driver = new RemoteWebDriver(new Uri("https://hub-cloud.browserstack.com/wd/hub/"), edgeCapability);
edgeCapability.AddAdditionalCapability("os_version", _windows.OSVersion);
edgeCapability.AddAdditionalCapability("browser_version", _browserDetails.BrowserVersion);
edgeCapability.AddAdditionalCapability("os", _windows.OS);
edgeCapability.AddAdditionalCapability("resolution", _browserDetails.Resolution);
edgeCapability.AddAdditionalCapability("project", _browserDetails.Project);
edgeCapability.AddAdditionalCapability("name", _browserDetails.Name);
edgeCapability.AddAdditionalCapability("build", _browserDetails.Build);
edgeCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser);
edgeCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey);
edgeCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug);
edgeCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console);
edgeCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), edgeCapability);

return driver;
}

private IWebDriver GetSafariDriver()
{
Version version = Assembly.GetExecutingAssembly().GetName().Version;

SafariOptions safariCapability = new SafariOptions();
safariCapability.AddAdditionalCapability("os_version", "Big Sur");
safariCapability.AddAdditionalCapability("browser", "Safari");
safariCapability.AddAdditionalCapability("browser_version", "latest");
safariCapability.AddAdditionalCapability("os", "OS X");
safariCapability.AddAdditionalCapability("resolution", "1920x1080");
safariCapability.AddAdditionalCapability("project", "HelpMyStreetFE");
safariCapability.AddAdditionalCapability("name", _featureContext.FeatureInfo.Title + " / " + _scenarioContext.ScenarioInfo.Title);
safariCapability.AddAdditionalCapability("build", $"Version {version} on {System.Environment.MachineName}");
safariCapability.AddAdditionalCapability("browserstack.user", Environment.GetEnvironmentVariable("BROWSERSTACK_USERNAME"));
safariCapability.AddAdditionalCapability("browserstack.key", Environment.GetEnvironmentVariable("BROWSERSTACK_ACCESS_KEY"));
safariCapability.AddAdditionalCapability("browserstack.debug", true);
safariCapability.AddAdditionalCapability("browserstack.console", "info");
safariCapability.AddAdditionalCapability("browserstack.networkLogs", "true");

IWebDriver driver = new RemoteWebDriver(new Uri("https://hub-cloud.browserstack.com/wd/hub/"), safariCapability);
safariCapability.AddAdditionalCapability("os_version", _macOS.OSVersion);
safariCapability.AddAdditionalCapability("browser_version", _browserDetails.BrowserVersion);
safariCapability.AddAdditionalCapability("os", _macOS.OS);
safariCapability.AddAdditionalCapability("resolution", _browserDetails.Resolution);
safariCapability.AddAdditionalCapability("project", _browserDetails.Project);
safariCapability.AddAdditionalCapability("name", _browserDetails.Name);
safariCapability.AddAdditionalCapability("build", _browserDetails.Build);
safariCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser);
safariCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey);
safariCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug);
safariCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console);
safariCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), safariCapability);

return driver;
}

private IWebDriver GetAndroidDriver()
{
ChromeOptions androidCapability = new ChromeOptions();
androidCapability.AddAdditionalCapability("browser", "Android", true);
androidCapability.AddAdditionalCapability("real_mobile", "true", true);
androidCapability.AddAdditionalCapability("device", "Samsung Galaxy S20", true);
androidCapability.AddAdditionalCapability("os_version", "10.0", true);
androidCapability.AddAdditionalCapability("project", _browserDetails.Project, true);
androidCapability.AddAdditionalCapability("name", _browserDetails.Name, true);
androidCapability.AddAdditionalCapability("build", _browserDetails.Build, true);
androidCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser, true);
androidCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey, true);
androidCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug, true);
androidCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console, true);
androidCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs, true);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), androidCapability);

return driver;
}

private IWebDriver GetIOSDriver()
{
SafariOptions iosCapability = new SafariOptions();
iosCapability.AddAdditionalCapability("browser", "iPhone");
iosCapability.AddAdditionalCapability("real_mobile", "true");
iosCapability.AddAdditionalCapability("device", "iPhone 12");
iosCapability.AddAdditionalCapability("os_version", "14");
iosCapability.AddAdditionalCapability("project", _browserDetails.Project);
iosCapability.AddAdditionalCapability("name", _browserDetails.Name);
iosCapability.AddAdditionalCapability("build", _browserDetails.Build);
iosCapability.AddAdditionalCapability("browserstack.user", _browserDetails.BrowserStackUser);
iosCapability.AddAdditionalCapability("browserstack.key", _browserDetails.BrowserStackAccessKey);
iosCapability.AddAdditionalCapability("browserstack.debug", _browserDetails.Debug);
iosCapability.AddAdditionalCapability("browserstack.console", _browserDetails.Console);
iosCapability.AddAdditionalCapability("browserstack.networkLogs", _browserDetails.NetworkLogs);

IWebDriver driver = new RemoteWebDriver(new Uri(URI), iosCapability);

return driver;
}
Expand Down
2 changes: 2 additions & 0 deletions HelpMyStreetFE.Specs/HelpMyStreetFE.Specs/Features/SiteNavigation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
@StartVolunteerBrowser
@AcceptAllCookies
@Desktop
Feature: SiteNavigation
Navigation using top menu bar on home page

@MaximiseWindows

Scenario Outline: Primary navigation (wide screen)
Given the volunteer's element #site-nav ul li:nth-child(<index>) a should have text <Name>
When the volunteer clicks the element #site-nav ul li:nth-child(<index>) a
Expand Down
Loading