Merge pull request #10 from Helsinki-NLP/fix/early-stop

plugging back early stopper
Helsinki-NLP · Sep 25, 2023 · 3b1678e · 3b1678e
2 parents ee91f21 + c72611b
commit 3b1678e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/onmt/trainer.py b/onmt/trainer.py
@@ -380,12 +380,12 @@ def train(
                         valid_stats=valid_stats,
                     )
 
-            #     # Run patience mechanism
-            #     if self.earlystopper is not None:
-            #         self.earlystopper(valid_stats, step)
-            #         # If the patience has reached the limit, stop training
-            #         if self.earlystopper.has_stopped():
-            #             break
+                # Run patience mechanism
+                if self.earlystopper is not None:
+                    self.earlystopper(valid_stats, step)
+                    # If the patience has reached the limit, stop training
+                    if self.earlystopper.has_stopped():
+                        break
 
             if self.model_saver is not None and (save_checkpoint_steps != 0 and step % save_checkpoint_steps == 0):
                 self.model_saver.save(step, moving_average=self.moving_average)