undo forward-hook side-effect #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waino
reviewed
Sep 25, 2023
onmt/trainer.py
Outdated
| @@ -447,6 +447,11 @@ def validate(self, valid_iter, moving_average=None, task=None): | |||
| # Set model back to training mode. | |||
| valid_model.train() | |||
|
|
|||
| # the forward hook `has_grad` was triggered, so we manually unset the flags to not fool the optim | |||
There was a problem hiding this comment.
This should work, as long as validation is never performed in the middle of an accumulation (a very reasonable assumption).
However, I think a better solution would be to modify the hook: have it check that module.training is set. If unset, then return without doing anything.
There was a problem hiding this comment.
the efficient thing would be to set param.has_grad = self.training, but that's a case of clarity vs. efficiency.
Maybe a big fat explanatory comment would suffice
added 2 commits
September 25, 2023 10:42
This reverts commit 5763591.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18