Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Automate AUR Publishing #3107

Merged
merged 7 commits into from
Oct 31, 2023
Merged

[CI] Automate AUR Publishing #3107

merged 7 commits into from
Oct 31, 2023

Conversation

flavioislima
Copy link
Member

@flavioislima flavioislima commented Oct 3, 2023

Github Workflow to update AUR after a new release.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Oct 3, 2023
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

.github/workflows/release_aur.yml Outdated Show resolved Hide resolved
@flavioislima
Copy link
Member Author

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Oct 6, 2023

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

electron depends on gtk3
snip from ldd output:

libgtk-3.so.0 => /usr/lib/libgtk-3.so.0 (0x00007f5b4d600000)

@flavioislima
Copy link
Member Author

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

electron depends on gtk3 snip from ldd output:

libgtk-3.so.0 => /usr/lib/libgtk-3.so.0 (0x00007f5b4d600000)

but we are not using electron from the system, so I dont see the point. The build from pacman we use already contains all the dependencies.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Oct 7, 2023

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

electron depends on gtk3 snip from ldd output:

libgtk-3.so.0 => /usr/lib/libgtk-3.so.0 (0x00007f5b4d600000)

but we are not using electron from the system, so I dont see the point. The build from pacman we use already contains all the dependencies.

not true, the current heroic pacman package doesn't ship gtk3, or a majority of the libraries that electron depends on

@CommandMC
Copy link
Collaborator

I cannot see any other difference besides the dependencies., do you?

You can see the full list of changes in this commit
They've...

  • set url to our official website (which, according to the AW, should be used if available)
  • corrected provides and conflicts (we provide heroic-games-launcher and also conflict with all other packages providing it)
  • used sha256sums instead of md5sums, which is generally preferred
  • changed the dependencies as you mentioned

@flavioislima
Copy link
Member Author

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

electron depends on gtk3 snip from ldd output:

libgtk-3.so.0 => /usr/lib/libgtk-3.so.0 (0x00007f5b4d600000)

but we are not using electron from the system, so I dont see the point. The build from pacman we use already contains all the dependencies.

not true, the current heroic pacman package doesn't ship gtk3, or a majority of the libraries that electron depends on

any reason why it is not breaking? or did it break to someone already because of these dependencies?
I am worried that we might not need gtk3 and we will force people to install it when installing heroic, it is being almost 3 years with this AUR repo and we never had these deps there.

@flavioislima
Copy link
Member Author

I cannot see any other difference besides the dependencies., do you?

You can see the full list of changes in this commit They've...

* set `url` to our official website (which, according to the AW, should be used if available)

* corrected `provides` and `conflicts` (we provide `heroic-games-launcher` and also conflict with all other packages providing it)

* used `sha256sums` instead of `md5sums`, which is generally preferred

* changed the dependencies as you mentioned

ok, done.

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Oct 20, 2023

A user on the AUR suggested this PKGBUILD instead, maybe we can build off that here?

doesn't look right to me, why Heroic would depend on gtk3? I cannot see any other difference besides the dependencies., do you?

electron depends on gtk3 snip from ldd output:

libgtk-3.so.0 => /usr/lib/libgtk-3.so.0 (0x00007f5b4d600000)

but we are not using electron from the system, so I dont see the point. The build from pacman we use already contains all the dependencies.

not true, the current heroic pacman package doesn't ship gtk3, or a majority of the libraries that electron depends on

any reason why it is not breaking? or did it break to someone already because of these dependencies? I am worried that we might not need gtk3 and we will force people to install it when installing heroic, it is being almost 3 years with this AUR repo and we never had these deps there.

oh if no one has complained then never mind, it might work just fine

edit: fyi: im not being ironic

@flavioislima
Copy link
Member Author

oh if no one has complained then never mind, it might work just fine

Not sure if you are being ironic or not but that is actually a valid point.

@flavioislima flavioislima merged commit 6eebabf into main Oct 31, 2023
13 checks passed
@flavioislima flavioislima deleted the ci/aut_aur branch October 31, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants