Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Linux Icon when sideloading games #3117

Merged

Conversation

SarthakD15
Copy link
Contributor

@SarthakD15 SarthakD15 commented Oct 6, 2023

There was a linux logo display issue when we click on add game.
I set up the code locally and test the issue. So there was an issue with displaying of linux logo. Then I wne t through the code and found that the value assigned to linux was 'linux' but it should be 'Linux' instead.
Solved the problem !!
<--- Put the description here --->


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

There was a linux logo display issue when we click on add game.
@flavioislima flavioislima changed the title Linux icon issue resolved [FIX] Linux Icon when sideloading games Oct 6, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing that!
⚔️

@flavioislima flavioislima merged commit 453275b into Heroic-Games-Launcher:main Oct 6, 2023
9 checks passed
@SarthakD15
Copy link
Contributor Author

Thank you :) !!

@SarthakD15
Copy link
Contributor Author

#3111 You may close this issue now as it got resolved :)

@arielj
Copy link
Collaborator

arielj commented Oct 6, 2023

@SarthakD15 when you make a PR, if you add "Closes #1234" or "Fixes #1234" in the description, when the PR is merged the associated issue gets closed automatically.

@SarthakD15
Copy link
Contributor Author

Ohh Got it ! I didn't know this.
Thanks @arielj :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants