Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Mark wineprefixes starting with XDG_RUNTIME_DIR as invalid #3271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Etaash-mathamsetty
Copy link
Member

Prevents more user error

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj
Copy link
Collaborator

arielj commented Nov 27, 2023

@Etaash-mathamsetty you have to explain your PRs better, what is the issue this is fixing? why is this fix implemented like this? it's hard to review your PRs without any context of the problem or the reasons of the fix

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Nov 27, 2023

context: #3075
oh there's not much context there either lol. Basically it's the same flatpak sandbox issue, people keep picking paths they don't have access through with the sandbox

@arielj
Copy link
Collaborator

arielj commented Nov 27, 2023

maybe instead of adding specific directories as invalid we can validate the path the users pick and check if it's writable instead? then we can cover any path and not only the ones we hardcode checks

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Nov 28, 2023

maybe instead of adding specific directories as invalid we can validate the path the users pick and check if it's writable instead? then we can cover any path and not only the ones we hardcode checks

I think those /run/user paths are writable, but I'll check if that's correct after trying it out

@flavioislima flavioislima added the pr:wip WIP, don't merge. label Nov 30, 2023
@flavioislima
Copy link
Member

WE already have a method on backend to validate if the path is writable or not so just use it and that should fix the issue @Etaash-mathamsetty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:wip WIP, don't merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants