Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] SystemInfo: Detect the Steam Deck OLED #3273

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

CommandMC
Copy link
Collaborator

@CommandMC CommandMC commented Nov 28, 2023

Detecting the OLED model isn't too difficult, its only difference is a new GPU PCI ID
Adding to that, both the system info text and page will now note the model name (LCD or OLED) if available

I've tested this on my LCD model, waiting for someone on Discord to test with their OLED Tested successfully on both SD LCD and SD OLED


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Detecting the OLED model isn't too difficult, its only difference is a
new GPU PCI ID
Adding to that, both the system info text and page will now note the
model name (LCD or OLED) if available
@CommandMC CommandMC added the pr:testing This PR is in testing, don't merge. label Nov 28, 2023
@CommandMC CommandMC self-assigned this Nov 28, 2023
@CommandMC CommandMC added pr:ready-for-review Feature-complete, ready for the grind! :P and removed pr:testing This PR is in testing, don't merge. labels Nov 29, 2023
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@flavioislima flavioislima merged commit bf1ff37 into main Nov 30, 2023
13 checks passed
@flavioislima flavioislima deleted the fix/sysinfo-steamdeck-oled branch November 30, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants