snap: initial manifest and fixes #4091
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
soumyaDghosh
force-pushed
the
snap-fixes
branch
from
46c2ec2 to
37577b9
Compare
flavioislima
requested review from
arielj,
flavioislima,
CommandMC and
imLinguin
soumyaDghosh
force-pushed
the
snap-fixes
branch
from
37577b9 to
f65a746
Compare
|
@soumyaDghosh can you run How can we build it locally? it is enough to setup snapcraft and run the build command from the snap directory? |
flavioislima
added
the
pr:ready-for-review
Yup simple setup snapcraft and build from the project's root directory. |
|
(note that it's |
soumyaDghosh
force-pushed
the
snap-fixes
branch
from
f65a746 to
4145994
Compare
I don't think the lint is failing due to my PR |
also |
The changes made in this PR also cause the lint to fail. We've had a brief issue where un-linted code got into the main branch, but this was resolved. Please
The issue you're referencing there is 3 years old, being resolved 2 years ago. |
soumyaDghosh
force-pushed
the
snap-fixes
branch
from
4145994 to
d885245
Compare
| if ! snapctl is-connected "gaming-mesa"; then | ||
| echo "ERROR: not connected to the gaming-mesa content interface." | ||
| echo "To connect:" | ||
| echo "sudo snap connect heroic:gaming-mesa gaming-graphics-core22" |
There was a problem hiding this comment.
So I understand this is something every user will have to do themselves after installing the Snap? Can we do this automatically somehow?
I just envision confused users that only install Heroic, try to launch it from their application launcher, and then nothing happens as they have to run this command, which is only printed out to the (in this situation nonexistent) console
There was a problem hiding this comment.
This file still seems very Steam-specific. Do we actually want/need it?
| - -usr/lib/*/libLLVM* | ||
| override-build: | | ||
| set -eux | ||
| patch -p1 < $CRAFT_PROJECT_DIR/dist.patch |
There was a problem hiding this comment.
Where does this patch come from?
| # alsa-mixin: | ||
| # plugin: dump | ||
| # source: https://github.com/diddlesnaps/snapcraft-alsa.git | ||
| # source-subdir: snapcraft-assets | ||
| # source-depth: 1 | ||
| # build-packages: | ||
| # - libasound2-dev | ||
| # stage-packages: | ||
| # - libasound2 | ||
| # - libasound2-plugins | ||
| # - yad | ||
| # stage: | ||
| # # restrict to only audio-related files - you need to ensure | ||
| # # that gtk3 is staged for yad to work correctly, to prompt | ||
| # # users to connect the alsa plug or proceed with pulseaudio. | ||
| # # | ||
| # # This helps prevent symbol conflicts in situations where | ||
| # # you're using a non-default library, such as those that the | ||
| # # gnome-3-34 extension for core18 provides. | ||
| # - etc/asound.conf | ||
| # - snap/command-chain/alsa-launch | ||
| # - usr/bin/yad* | ||
| # - usr/lib/*/alsa-lib | ||
| # - usr/lib/*/libasound* | ||
| # - usr/lib/*/libasyncns* | ||
| # - usr/lib/*/libdnsfile* | ||
| # - usr/lib/*/libFLAC* | ||
| # - usr/lib/*/libjack* | ||
| # - usr/lib/*/libpulse* | ||
| # - usr/lib/*/libsamplerate* | ||
| # - usr/lib/*/libsndfile* | ||
| # - usr/lib/*/libspeex* | ||
| # - usr/lib/*/libvorbis* | ||
| # - usr/lib/*/pulseaudio | ||
| # - usr/share/alsa |
There was a problem hiding this comment.
Probably want to remove entries like this completely if they're not needed. Otherwise you'll have people go "Why is this here again?" a year from now
This is the initial manifest. I have also created a patch to get the actual release details of the OS. If you want, I can also create a PR for the build and release.
Use the following Checklist if you have changed something on the Backend or Frontend: