Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Maintain proper cursor over SVGs on Game page #4213

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

Flexicon
Copy link
Contributor

Fixes #4212

Issue

On Game Info SVG tags, we are currently applying a cursor text style, which is a bit jarring on SVGs inside button tags.

Before

before.mov

After

after.mov

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Dec 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Flexicon
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@Flexicon Flexicon requested a review from arielj December 27, 2024 13:47
@Flexicon Flexicon changed the title [Fix] Maintain proper cursor on Game page with SVGs inside buttons [Fix] Maintain proper cursor over SVGs on Game page Dec 27, 2024
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@arielj arielj merged commit d7e42b2 into Heroic-Games-Launcher:main Dec 27, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursors show as text on SVGs inside buttons inside of Game page view
3 participants