Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Use Steam Runtime" #4237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove "Use Steam Runtime" #4237

wants to merge 1 commit into from

Conversation

CommandMC
Copy link
Collaborator

This option had two use cases:

  • You're running a Windows game with Proton
  • You're running a Linux-native game

Umu now covers both of these use cases. Running Proton with umu is already implemented & done by default, while Linux-native apps still require work in Heroic.
I would however argue that almost no-one used Steam RT for Linux-native games (Linux native games themselves are rare, them working is even rarer, and this option being found by the user & helping virtually does not happen). If demand for this option is indeed there, we should look into using umu for it.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 4, 2025
@CommandMC CommandMC requested a review from a team January 4, 2025 13:44
@CommandMC CommandMC self-assigned this Jan 4, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team January 4, 2025 13:44
@arielj
Copy link
Collaborator

arielj commented Jan 4, 2025

If there are users playing games that were fixed using this, those games will break.

Maybe it's better to only support the steam runtime for linux native games instead of completely removing it? or is UMU capable of handling those cases? in that case we would need a way to migrate those users from using the steam runtime to using UMU automatically

without that this PR can break games that were already working, I know many discord support threads with native games are solved by enabling this so there are users using this options

@CommandMC
Copy link
Collaborator Author

Maybe it's better to only support the steam runtime for linux native games instead of completely removing it? or is UMU capable of handling those cases?

Umu can run arbitrary Linux executables in the runtime, yes. This is however only a feature in 1.1.4, while the version in Lutris' API (which we use) is 1.1.3. So a first step would have to be to update that.

in that case we would need a way to migrate those users from using the steam runtime to using UMU automatically

That would be ideal, yes

I know many discord support threads with native games are solved by enabling this so there are users using this options

Huh, must've missed those. I honestly never saw anyone use this option (at most using it with Proton)


I'll go poke the umu guys to update the release then. After that I'll update this PR to migrate Linux-native apps from Steam RT to umu

@arielj
Copy link
Collaborator

arielj commented Jan 4, 2025

Huh, must've missed those. I honestly never saw anyone use this option (at most using it with Proton)

well, when I say many I meant many of the linux native reports, not that there are many reports like that but I do remember seeing that

I have one in my notes that got fixed with the steam runtime too, Mana Spark linux native, so I could test this once updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants