fix. assemblies referencing unnecessary references

Hertzole · Jan 16, 2024 · 496016e · 496016e
1 parent 0a167bd
commit 496016e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -103,7 +103,7 @@ jobs:
         uses: actions/setup-dotnet@v4
         with:
           dotnet-version: |
-            6.x
+            8.x
 
       - name: Install Java
         uses: actions/setup-java@v4
@@ -154,8 +154,9 @@ jobs:
            /o:"hertzole" \
            /k:"scriptable-values" \
            /d:sonar.host.url=https://sonarcloud.io \
-           /d:sonar.verbose=true \
+           /d:sonar.verbose=false \
            /d:sonar.token=$SONAR_TOKEN \
+           /d:sonar.cs.nunit.reportsPaths=Tests/**.xml \
            /d:sonar.cs.opencover.reportsPaths=Coverage/workspace-opencov/**.xml
           dotnet build scriptable-values.sln
           ./dotnet-sonarscanner end /d:sonar.token=$SONAR_TOKEN
diff --git a/Packages/se.hertzole.scriptable-values/Editor/Hertzole.ScriptableValues.Editor.asmdef b/Packages/se.hertzole.scriptable-values/Editor/Hertzole.ScriptableValues.Editor.asmdef
@@ -9,7 +9,7 @@
     ],
     "excludePlatforms": [],
     "allowUnsafeCode": false,
-    "overrideReferences": false,
+    "overrideReferences": true,
     "precompiledReferences": [],
     "autoReferenced": true,
     "defineConstraints": [],

diff --git a/Packages/se.hertzole.scriptable-values/Runtime/Hertzole.ScriptableValues.asmdef b/Packages/se.hertzole.scriptable-values/Runtime/Hertzole.ScriptableValues.asmdef
@@ -11,20 +11,17 @@
     "includePlatforms": [],
     "excludePlatforms": [],
     "allowUnsafeCode": false,
-    "overrideReferences": false,
-    "precompiledReferences": [],
+    "overrideReferences": true,
+    "precompiledReferences": [
+        ""
+    ],
     "autoReferenced": true,
     "defineConstraints": [],
     "versionDefines": [
         {
             "name": "com.unity.addressables",
             "expression": "",
             "define": "SCRIPTABLE_VALUES_ADDRESSABLES"
-        },
-        {
-            "name": "com.unity.netcode.gameobjects",
-            "expression": "",
-            "define": "SCRIPTABLE_VALUES_NGO"
         }
     ],
     "noEngineReferences": false