feat: add new sketch and pad global configuration options applicable to all diagrams
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is from #6 |
|
Oops I see I accidentally committed some ugly SVGs from testing the |
michaeltoohig
force-pushed
the
feat-additional-config
branch
from
465b193 to
ff337b8
Compare
|
@HiDeoo I just wanted to bring your attention I believe this PR is ready. |
HiDeoo
approved these changes
Apr 27, 2024
HiDeoo
changed the title
sketch and pad global configuration options applicable to all diagrams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Add
sketchandpadvalues to the global config.Why
So that I do not need to manually add
sketch=trueto everyd2code block if I want my website to use sketch style by default. The same for padding.How
I updated the handling of attributes and added new
sketchandpadconfig options. Plus, I added a test but I'm not sure I did that correctly.Screenshots
If applicable, add screenshots to help explain what is being modified.
I want to note that I removed the default pad and perhaps you want to return that value to 100.