Merge pull request optuna#5702 from porink0424/fix/reduce-select-in-s…

…et_trial_param-by-passing-study_id

Reduce `SELECT` statements by passing `study_id` to `check_and_add` in `TrialParamModel`

optuna/storages/_rdb/models.py

@@ -349,19 +349,17 @@ class TrialParamModel(BaseModel):
         TrialModel, backref=orm.backref("params", cascade="all, delete-orphan")
     )
 
-    def check_and_add(self, session: orm.Session) -> None:
-        self._check_compatibility_with_previous_trial_param_distributions(session)
+    def check_and_add(self, session: orm.Session, study_id: int) -> None:
+        self._check_compatibility_with_previous_trial_param_distributions(session, study_id)
         session.add(self)
 
     def _check_compatibility_with_previous_trial_param_distributions(
-        self, session: orm.Session
+        self, session: orm.Session, study_id: int
     ) -> None:
-        trial = TrialModel.find_or_raise_by_id(self.trial_id, session)
-
         previous_record = (
             session.query(TrialParamModel)
             .join(TrialModel)
-            .filter(TrialModel.study_id == trial.study_id)
+            .filter(TrialModel.study_id == study_id)
             .filter(TrialParamModel.param_name == self.param_name)
             .first()
         )

optuna/storages/_rdb/storage.py

@@ -595,7 +595,7 @@ def _set_trial_param_without_commit(
             distribution_json=distributions.distribution_to_json(distribution),
         )
 
-        trial_param.check_and_add(session)
+        trial_param.check_and_add(session, trial.study_id)
 
     def _check_and_set_param_distribution(
         self,
@@ -616,7 +616,7 @@ def _check_and_set_param_distribution(
                 param_name=param_name,
                 param_value=param_value_internal,
                 distribution_json=distributions.distribution_to_json(distribution),
-            ).check_and_add(session)
+            ).check_and_add(session, study_id)
 
     def get_trial_param(self, trial_id: int, param_name: str) -> float:
         with _create_scoped_session(self.scoped_session) as session: