Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Apply https://github.com/optuna/optuna/pull/5217 on https://github.com/HideakiImamura/optuna/pull/6 #7

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/checks-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
schedule:
- cron: '0 23 * * SUN-THU'
workflow_dispatch:
pull_request: {}

concurrency:
group: ${{ github.workflow }}-${{ github.ref == 'refs/heads/master' && github.run_number || github.ref }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/windows-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Tests
if: ${{ github.event_name != 'schedule' && github.event_name != 'workflow_dispatch' }}
run: |
pytest -m "not integration and not slow"
pytest -m "not integration"
env:
MPLBACKEND: "QtAgg" # Use QtAgg as matplotlib backend.

Expand Down Expand Up @@ -118,6 +118,8 @@ jobs:
pip install --progress-bar off .[optional]
pip install --progress-bar off .[integration]
pip install "distributed<2023.3.2"
# TODO(nabenabe0928): Remove the version constraint on Torch.
pip install "torch<2.2.0"

- name: Output installed packages
run: |
Expand Down
2 changes: 1 addition & 1 deletion optuna/integration/pytorch_distributed.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
with try_import() as _imports:
import torch
import torch.distributed as dist
from torch.distributed import ProcessGroup # type: ignore[attr-defined]
from torch.distributed import ProcessGroup


if TYPE_CHECKING:
Expand Down
6 changes: 3 additions & 3 deletions tests/artifacts_tests/test_boto3.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@


try:
from moto import mock_aws
# TODO(nabenabe0928): Replace it with `from moto import mock_aws` after dropping Python3.7.
from moto import mock_aws # type: ignore[attr-defined]
except ImportError:
from moto import mock_s3 as mock_aws

from moto import mock_s3 as mock_aws # type: ignore[attr-defined,no-redef]

if TYPE_CHECKING:
from collections.abc import Iterator
Expand Down
Loading