Add filters filters for new buttons to filter out the internships on the basis of role and industry #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the basis of selected role and industry Added the new filter for sorting out the internships based on Role and Industry -Made changes in the DataBase.json file according to the filters -Updated the CSS portion to make filters according to the layout and style of the website -Updated according to the earlier reviewed changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello @HimanshuNarware can you review it now |
|
Can you improve the ui of select tag, like spacing of options in drop down, colour and size of select tag, also show not found or something like that if no results available for selected option @nikki-05 |
Sure sir |
-Updated the CSS for the select option -Updated the filter in such a way when a user selects both or one in one/both the categories then the message is displayed along with the default internships
|
is it okay now? |
|
Fixes #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixes #478
Added the new filter for sorting out the internships based on Role and Industry
-Made changes in the DataBase.json file according to the filters
-Updated the CSS portion to make filters according to the layout and style of the website
-Updated according to the earlier reviewed changes
Features:
-The filter shows default internships even without selecting any filter
-It filters out the internships when any role/ industry is selected
-the style of the filter matches with the page
Here is the attached image below :