Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building timing reports with dune #2234

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Feb 25, 2025

This PR adds support for building timing-html files as mentioned in #2230.

TODO

  • Also put .timing files somewhere, for now only .timing.html is built
  • Generate report of slowest lines
  • Generate comparison report from last report

This substitutes the working directory instead of hard coding it like
before. This means that dune will use `_build/default` when used
normally, and the script can be run in a sandboxed action in
`_build/.sandbox/HASH/...`.

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter changed the title dune: enable directory targets building timing reports with dune Feb 25, 2025
@jdchristensen
Copy link
Collaborator

This looks like a nice idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants