UI improvements #27
Merged
UI improvements #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-krechan
approved these changes
May 21, 2024
| @@ -14,7 +15,8 @@ | |||
| "format:check": "prettier '**/*.{js,jsx,ts,tsx,html,css,scss,json,yml,md}' --check", | |||
| "format": "prettier '**/*.{js,jsx,ts,tsx,html,css,scss,json,yml,md}' --write", | |||
| "ng-openapi-gen": "ng-openapi-gen --input openapi.yml --output ./src/app/core/api --indexFile=true", | |||
| "lint": "ng lint" | |||
| "lint": "ng lint", | |||
There was a problem hiding this comment.
what linter do we use?
There was a problem hiding this comment.
Eslint with angular plugins. I did not change anything regarding the linter in this PR. I actually have a draft pr open for the linting, since we currently do not lint the whole project.
| <div class="flex flex-col items-start mt-2 h-auto w-full"> | ||
| <select | ||
| id="format-version-select" | ||
| class="inline-block border-2 border-white rounded bg-[#F6ECED] py-3 ps-3 pe-24 focus:outline-0 w-full" |
There was a problem hiding this comment.
bg-[#F6ECED] is this a background color?
Is it possible to define colours in tailwind globally?
There was a problem hiding this comment.
Yes sure, once we have the full design we should define more stuff
This was referenced May 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.