Enable sandbox by default for homebrew/core #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
|
👍 x 💯 x 💯 once CI is a happy happy robot. |
|
For those looking for further background reading on the Sandbox, I found Homebrew/legacy-homebrew#37552 to be helpful. |
Simplify checking if we’re going to sandbox a test with `Sandbox.test?`.
Add a new `Sandbox.formula?` method to see if a given formula should be sandboxed. Use the formula to check its tap against a list of pre-approved taps where we know every formula builds under the sandbox (currently just homebrew/core).
|
😻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Now that Homebrew/homebrew-core#342 is finished we can now enable the sandbox by default for all users using the homebrew/core tap. This whitelist system should give users of the most widely used tap better security without breaking other taps that are working without the sandbox. We can aim to get all the Homebrew/homebrew-* taps supported in here eventually and allow the community to submit PRs if they want their tap protected by the sandbox. Eventually we may turn this on for all taps (but not for a while).