Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feishin 0.9.0 (new cask) #186699

Closed
wants to merge 1 commit into from
Closed

Feishin 0.9.0 (new cask) #186699

wants to merge 1 commit into from

Conversation

kozlek
Copy link
Contributor

@kozlek kozlek commented Sep 26, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@kozlek kozlek changed the title feat(feishin): Add Feishin cask version 0.9.0 Feishin 0.9.0 (new cask) Sep 26, 2024
@kozlek
Copy link
Contributor Author

kozlek commented Sep 26, 2024

This PR will obviously not pass the CI due to the missing signature of the app.
However if this is truly blocking, I would recommend to update the PR skeleton to add the --signing hook to the brew audit checkup item.

@bevanjkay
Copy link
Member

bevanjkay commented Sep 26, 2024

However if this is truly blocking, I would recommend to update the PR skeleton to add the --signing hook to the brew audit checkup item.

Yes, the signing audit is a blocking failure, so unfortunately we cannot accept this cask into homebrew-cask.

The --signing argument is implied by the --new flag when running brew audit --cask --new <cask>, which is included in the PR template.

@Maaago
Copy link

Maaago commented Nov 1, 2024

jeffvli/feishin#818 updated the cask file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants