Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animdl: vendor Python deps #163439

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

timsutton
Copy link
Member

@timsutton timsutton commented Feb 20, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow-on from #162599, this project needed newer lxml and yarl dependency updates. Left a breadcrumb over at justfoolingaround/animdl#301. I left in a patch as a way to true up the dependency changes in one place, but the patch isn't strictly needed in order for it to build, so am fine if it's preferable to take it out and just put in comments at the top of resource blocks.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 20, 2024
@chenrui333 chenrui333 added python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project and removed automerge-skip `brew pr-automerge` will skip this pull request labels Feb 20, 2024
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, great work! I forgot to circle back to this after we figured out what we were keeping, so thanks for that as well 😅

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 20, 2024
Merged via the queue into Homebrew:master with commit eec268b Feb 20, 2024
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants