Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lz4: fix Cellar reference in .pc file #181636

Merged
merged 4 commits into from
Aug 19, 2024
Merged

lz4: fix Cellar reference in .pc file #181636

merged 4 commits into from
Aug 19, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See #181633.

  • lz4: fix Cellar reference in .pc file
  • flann: revision bump (lz4 1.10.0)

This breaks dependents when they hard-code references to lz4's Cellar
path.
@carlocab carlocab added CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing labels Aug 19, 2024
@carlocab carlocab mentioned this pull request Aug 19, 2024
6 tasks
@carlocab carlocab marked this pull request as ready for review August 19, 2024 05:47
@carlocab carlocab added the ready to merge PR can be merged once CI is green label Aug 19, 2024
@carlocab carlocab mentioned this pull request Aug 19, 2024
carlocab added a commit that referenced this pull request Aug 19, 2024
@carlocab
Copy link
Member Author

carlocab commented Aug 19, 2024

For flann indirect linkage: #181648

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 19, 2024
Merged via the queue into master with commit be7d2a5 Aug 19, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the lz4-cellar-pc branch August 19, 2024 10:55
@branchvincent branchvincent mentioned this pull request Aug 19, 2024
6 tasks
@cho-m cho-m mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants