Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete core formula bottling #2194

Closed
wants to merge 8 commits into from
Closed

Complete core formula bottling #2194

wants to merge 8 commits into from

Conversation

MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

With this PR we now have at least one bottle for every formula in homebrew-core. vmalloc had some installs since analytics began but cannot be downloaded any more and the homepage isn't up either. The rest had 0️⃣ installations. I added ld64 bottles because I'm a completionist and had Leopard/Snow Leopard VMs handy.

I believe now this has been done we can enable the sandbox for users installing formulae in homebrew/core. Correct me if I'm wrong, here.

CC @mistydemeo @xu-cheng

@BrewTestBot BrewTestBot added the in progress Stale bot should stay away label Jun 20, 2016
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jun 20, 2016
53 tasks
@MikeMcQuaid
Copy link
Member Author

I believe now this has been done we can enable the sandbox for users installing formulae in homebrew/core. Correct me if I'm wrong, here.

I am wrong, still a few more to do: #342

@DomT4
Copy link
Member

DomT4 commented Jun 20, 2016

All of the boneyardings here seem reasonable to me, at least.

@UniqMartin
Copy link
Contributor

I agree with all of the changes made here. Filed #2195 to complement this one and get one step closer to achieving the stated goal of this PR.

@BrewTestBot BrewTestBot removed the in progress Stale bot should stay away label Jun 21, 2016
@MikeMcQuaid MikeMcQuaid deleted the add-bottles branch June 21, 2016 08:37
@UniqMartin
Copy link
Contributor

👍 👏 (And sorry for temporarily creating a merge conflict for you.)

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants