Apply suggestions from code review

Co-authored-by: fn ⌃ ⌥ <[email protected]>
Homebrew · Nov 18, 2021 · 819d12a · 819d12a
1 parent a0167a1
commit 819d12a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/tests/formulae_dependents.rb b/lib/tests/formulae_dependents.rb
@@ -176,9 +176,10 @@ def install_dependent(dependent, testable_dependents, args:, build_from_source:
             dependent,
             cache_key: "test-bot-link",
           ) do |dep_dependent, dependency|
-            Dependency.prune if dependency.build? && !dependency.test?
-            Dependency.prune if dependency.test? && dep_dependent != dependent
-            dependency_f = dependency.to_formula
+            next if !dependency.build? && !dependency.test?
+            next if dependency.test? && dep_dependent == dependent
+
+            Dependency.prune
             Dependency.skip if dependency_f.keg_only?
           end.map(&:to_formula)