-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect all package changes #1006
base: master
Are you sure you want to change the base?
feat: detect all package changes #1006
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
3f2a1bf
to
e47f98c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
I guess it feels a little half-way for now; I'd probably rather it either moves to entirely moving things over to packages or having separate formulae/casks for variables and flags. There's probably always going to warrant a need for some different classes for Formulae*/Casks*
Doesn't every tap use this function by default? That would be a lot of people who suddenly have their tap broken if we remove the I'm fine splitting up the variables and/or making a combination. But just to make sure: you're only talking about this method right? You're not looking for me to add casks to all flags in this PR. |
It does but we can/should change that in Homebrew/brew and add a deprecation.
I think it's fine to have for now but I guess I'm a little confused as to how it ends up being useful when only detection is done and nothing else? |
Since detection is a separate step, it allows me to move another part of cask CI to testbot. Everything after that will take more work so I'd like to do them separately |
Ok, makes sense. If it's useful as-is: great. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
e47f98c
to
985e984
Compare
Updated to be specific to casks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks @SMillerDev!
81625cd
to
c181e87
Compare
Good to 🚢 when CI is 🟢 |
I have no clue why CI could be failing, as far as I can tell it should be bright green |
44a86fe
to
64da960
Compare
Looks like CI is perhaps legitimately broken. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
64da960
to
f606778
Compare
This should allow us to use this flow in homebrew/cask too.