Revert "formulae_dependents: prune build deps when linking test deps"

[carlocab]

This still doesn't fix the overzealous linking of formulae,
unfortunately. See Homebrew/homebrew-core#89621.

This reverts commit 85aaf19.

[carlocab]

Sorry @FnControlOption, this didn't work. Thanks anyway!

[carlocab]

Btw, @MikeMcQuaid, I'm not able to merge this (merge button is greyed out), but this (and #717) should be ready to go.

[Bo98]

This probably would have worked if we did:

dependent.recursive_dependencies do |dep_dependent, dependency|
  Dependency.prune if dependency.build? && !dependency.test?
  Dependency.prune if dependency.test? && dep_dependent != dependent

[MikeMcQuaid]

@carlocab should be fixed now, can you try again?

[carlocab]

Yep, merge button is green. Thanks!

This probably would have worked if we did:

dependent.recursive_dependencies do |dep_dependent, dependency|
  Dependency.prune if dependency.build? && !dependency.test?
  Dependency.prune if dependency.test? && dep_dependent != dependent

While this does fix the linked CI error, this does not seem to fix the original error we wanted to fix. Our test cases are mathblibtools and phplint. We need: coreutils to be linked when dependent is mathlibtools, and we need httpd to be not linked when dependent is phplint. We get the latter but not the former:

# linked.rb
require 'formula'

def puts_linked(dependent)
  dependent.recursive_dependencies do |dep_dependent, dependency|
    Dependency.prune if dependency.build? && !dependency.test?
    Dependency.prune if dependency.test? && dep_dependent != dependency

    dependency_f = dependency.to_formula
    Dependency.skip if dependency_f.keg_only?
    puts dependency_f.full_name
  end
end

puts ARGV[0]
puts_linked(Formula[ARGV[0]])

Here's what we get:

❯ brew ruby linked.rb "mathlibtools" | rg -q 'coreutils'; echo $?
1
❯ brew ruby linked.rb "phplint" | rg -q 'httpd'; echo $?
1

[Bo98]

Your != condition is wrong. It should be dep_dependent != dependent.

[carlocab]

And here I thought I double-checked that... and yes, it works:

❯ brew ruby linked.rb "mathlibtools"
mathlibtools
lean
coreutils
gmp
gmp
jemalloc
gdbm
mpdecimal
ca-certificates
xz
six

This seems to have a bunch of duplicates though which we don't have by just iterating over recursive_dependencies. It's possible (likely?) this is more correct though.

❯ brew ruby linked.rb "phplint" | wc -l
60
❯ brew ruby linked.rb "phplint" | sort | uniq | wc -l
36

[Bo98]

This seems to have a bunch of duplicates

You should take the return value and print that rather than treat the block like .each. The block passed here is a filter and should do nothing more than that.

[carlocab]

So we'd need to move the brew link step outside the block too. Ok, let's see...

[carlocab]

Edit: Ah, never mind. Same typo.

Not sure what I'm doing wrong here:

# linked.rb
require 'formula'

def linked(dependent)
  dependent.recursive_dependencies do |dep_dependent, dependency|
    Dependency.prune if dependency.build? && !dependency.test?
    Dependency.prune if dependency.test? && dep_dependent != dependency

    dependency_f = dependency.to_formula
    Dependency.skip if dependency_f.keg_only?
  end
end

puts linked(Formula[ARGV[0]]).map(&:to_s)

❯ brew ruby linked.rb "mathlibtools"
gdbm
mpdecimal
ca-certificates
xz
six

No more coreutils.