fix DUP opcode validation (DNAProject#420)

smartcontract/test/panic_test.go

@@ -24,6 +24,8 @@ import (
 	"github.com/ontio/ontology/common/log"
 	"github.com/ontio/ontology/core/types"
 	. "github.com/ontio/ontology/smartcontract"
+	"github.com/ontio/ontology/vm/neovm"
+	"github.com/stretchr/testify/assert"
 	"os"
 	"testing"
 )
@@ -71,3 +73,29 @@ func TestRandomCodeCrash(t *testing.T) {
 		}
 	}
 }
+
+func TestOpCodeDUP(t *testing.T) {
+	log.InitLog(4)
+	defer func() {
+		os.RemoveAll("Log")
+	}()
+
+	config := &Config{
+		Time:   10,
+		Height: 10,
+		Tx:     &types.Transaction{},
+	}
+
+	var code = []byte{byte(neovm.DUP)}
+
+	sc := SmartContract{
+		Config:     config,
+		Gas:        10000,
+		CloneCache: nil,
+	}
+	engine, _ := sc.NewExecuteEngine(code)
+	_, err := engine.Invoke()
+
+	assert.NotNil(t, err)
+
+}

vm/neovm/opcode_exec.go

@@ -72,7 +72,7 @@ var (
 		XTUCK:           {Opcode: XTUCK, Name: "XTUCK", Exec: opXTuck, Validator: validateXTuck},
 		DEPTH:           {Opcode: DEPTH, Name: "DEPTH", Exec: opDepth},
 		DROP:            {Opcode: DROP, Name: "DROP", Exec: opDrop, Validator: validateCount1},
-		DUP:             {Opcode: DUP, Name: "DUP", Exec: opDup},
+		DUP:             {Opcode: DUP, Name: "DUP", Exec: opDup, Validator: validateCount1},
 		NIP:             {Opcode: NIP, Name: "NIP", Exec: opNip, Validator: validateCount2},
 		OVER:            {Opcode: OVER, Name: "OVER", Exec: opOver, Validator: validateCount2},
 		PICK:            {Opcode: PICK, Name: "PICK", Exec: opPick, Validator: validatePick},