Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

required check accept fragmentspread #1411

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joleeee
Copy link

@joleeee joleeee commented Jan 13, 2025

Fixes #1410

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jan 13, 2025

⚠️ No Changeset found

Latest commit: 89b357a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 89b357a
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/678515756dd3400008fdd76a

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 89b357a
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/67851575b84e0e0008b573c8

@AlecAivazis
Copy link
Collaborator

Thanks for putting this together @joleeee! I think the change makes sense so once you've added a changeset and a test here it should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to mark parent as @required if parent is nullable due to child being a nullable fragment
2 participants