Register evm (and other missing) module grpc routes endpoints (sei-pr…

…otocol#1717) * - Register evm module endpoints - Register epoch module endpoints * - Tests for adding routes * - Update test
Hridoy000368 · Jun 10, 2024 · 1c7253b · 1c7253b
1 parent 3ea043e
commit 1c7253b
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 2 deletions.
diff --git a/x/epoch/module.go b/x/epoch/module.go
@@ -1,6 +1,7 @@
 package epoch
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 
@@ -77,7 +78,9 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo
 func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {}
 
 // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module.
-func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {}
+func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
+	_ = types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx))
+}
 
 // GetTxCmd returns the capability module's root tx command.
 func (a AppModuleBasic) GetTxCmd() *cobra.Command {

diff --git a/x/epoch/module_test.go b/x/epoch/module_test.go
@@ -1,6 +1,8 @@
 package epoch_test
 
 import (
+	"github.com/cosmos/cosmos-sdk/client"
+	"github.com/grpc-ecosystem/grpc-gateway/runtime"
 	"testing"
 	"time"
 
@@ -35,6 +37,22 @@ func TestBasic(t *testing.T) {
 	require.Equal(t, appModule.EndBlock(ctx, abci.RequestEndBlock{}), []abci.ValidatorUpdate{})
 }
 
+// This test is just to make sure that the routes can be added without crashing
+func TestRoutesAddition(t *testing.T) {
+	testApp := app.Setup(false, false)
+	appModule := epoch.NewAppModule(
+		testApp.AppCodec(),
+		testApp.EpochKeeper,
+		testApp.AccountKeeper,
+		testApp.BankKeeper,
+	)
+
+	mux := runtime.NewServeMux()
+	appModule.RegisterGRPCGatewayRoutes(client.Context{}, mux)
+
+	require.NotNil(t, appModule)
+}
+
 func TestExportGenesis(t *testing.T) {
 	t.Parallel()
 	// Create a mock context and keeper

diff --git a/x/evm/module.go b/x/evm/module.go
@@ -1,6 +1,7 @@
 package evm
 
 import (
+	"context"
 	"encoding/json"
 	"fmt"
 	"math"
@@ -75,7 +76,9 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo
 func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {}
 
 // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module.
-func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {}
+func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
+	_ = types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx))
+}
 
 // GetTxCmd returns the capability module's root tx command.
 func (a AppModuleBasic) GetTxCmd() *cobra.Command {

diff --git a/x/evm/module_test.go b/x/evm/module_test.go
@@ -1,6 +1,8 @@
 package evm_test
 
 import (
+	"github.com/cosmos/cosmos-sdk/client"
+	"github.com/grpc-ecosystem/grpc-gateway/runtime"
 	"math"
 	"math/big"
 	"testing"
@@ -150,3 +152,13 @@ func TestAnteSurplus(t *testing.T) {
 	// ante surplus should be cleared
 	require.Equal(t, uint64(0), k.GetAnteSurplusSum(ctx).Uint64())
 }
+
+// This test is just to make sure that the routes can be added without crashing
+func TestRoutesAddition(t *testing.T) {
+	k, _ := testkeeper.MockEVMKeeper()
+	appModule := evm.NewAppModule(nil, k)
+	mux := runtime.NewServeMux()
+	appModule.RegisterGRPCGatewayRoutes(client.Context{}, mux)
+
+	require.NotNil(t, appModule)
+}