Preserve multiple Set-Cookie
headers
#1278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ungroups
Set-Cookie
headers since each header should appear independently. According to MDN:For example, the following is correct:
While the following is incorrect:
This PR achieves this by:
formatHeaders
function inutils/misc.ts
that treatsset-cookie
as a special case.private formatHeaders
function fromHttpResponseTextDocumentView
and updating all calls to use the new utilityformatHeaders
function.private static formatHeaders
function fromHttpResponseWebview
and updating all calls to use the new utilityformatHeaders
function.getFullResponseString
inHttpResponseWebview
to use the new utilityformatHeaders
function.createRequestInTempFile
inHistoryController
to use the new utilityformatHeaders
function.Fixes #722