Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Fix follow and shout status #213

Merged
merged 16 commits into from
Mar 8, 2019
Merged

Conversation

appinteractive
Copy link
Member

@appinteractive appinteractive commented Mar 3, 2019

Fix

Relates to

Human-Connection/Nitro-Backend#201

Todos

  • introduce new (un)shout and (un)follow mutations
  • add unfollw and unshout button states
  • disabled shouting of own content
  • disabled following of itself
  • write integration tests

@appinteractive appinteractive changed the title Fix follow and shout status [WIP] Fix follow and shout status Mar 3, 2019
@pr-triage pr-triage bot removed the PR: unreviewed label Mar 3, 2019
@Tirokk
Copy link
Member

Tirokk commented Mar 6, 2019

Hey @appinteractive , function and looks super! 👍🏼

I have one little thing problem:

  • If you are in a post of somebody else …
  • You hover over the link of the author …
  • A floating window appears with the counts of the followers and the counts of his or her posts etc. …
  • You are a non follower and click on following
  • the followers count does not increase. See screenshots …
  • What is the button at the right side of the following button for? I can not see any functionality.

bildschirmfoto 2019-03-06 um 15 14 06

bildschirmfoto 2019-03-06 um 15 14 16

@appinteractive
Copy link
Member Author

… the followers count does not increase.

Yeah thats becaus it would be error prune to hack it into the state right now. There has to be more work done, maybe using subscriptions or something in that direction. Could you open an issue for that case?

What is the button at the right side of the following button for? I can not see any functionality.

That button is prepared for the blacklist and is (or will be) implemented in that pr. #12

@Tirokk
Copy link
Member

Tirokk commented Mar 6, 2019

I created therefore issue #227 .

@appinteractive appinteractive changed the title [WIP] Fix follow and shout status Fix follow and shout status Mar 8, 2019
@appinteractive appinteractive merged commit 243d604 into master Mar 8, 2019
@appinteractive appinteractive deleted the distinct-shouts-and-follows branch March 8, 2019 14:33
@appinteractive appinteractive added this to the Fortuna milestone Mar 8, 2019
roschaefer added a commit that referenced this pull request Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants