Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and setup feathers-vuex #292

Closed
wants to merge 2 commits into from
Closed

Conversation

roschaefer
Copy link
Contributor

and configure it at runtime, yay!

@roschaefer roschaefer mentioned this pull request Sep 20, 2018
4 tasks
@Lulalaby
Copy link
Contributor

Fixed conflicts

@Lulalaby
Copy link
Contributor

Check passed 💃

@Lulalaby
Copy link
Contributor

Lulalaby commented Oct 4, 2018

@roschaefer this seems ready :3

@roschaefer
Copy link
Contributor Author

I think we could merge that, too

@roschaefer roschaefer requested a review from Lulalaby October 5, 2018 15:56
Copy link
Member

@appinteractive appinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session on the server side (SSR) is not destroyed which leads to the following scenario:

  1. login as admin ([email protected])
  2. logout
  3. login as regular user ([email protected])
  4. refresh page after you are logged in
  5. see that you are logged in again as the last user (admin) instead of your last loggin (user)

You need to remove that session also on the server side, maybe there is a cookie still flying around in the browser which is then send on SSR and the backend responds with the logged in user from the token in the cookie.

```
session on the server side (SSR) is not destroyed which leads to the following
scenario:

1. login as admin ([email protected])
2. logout
3. login as regular user ([email protected])
4. refresh page after you are logged in
5. see that you are logged in again as the last user (admin) instead of your
   last loggin (user)
You need to remove that session also on the server side, maybe there is a cookie
still flying around in the browser which is then send on SSR and the backend
responds with the logged in user from the token in the cookie.
```

This is not possible now, as the lazy-loading happens with `app.$api` and
not the socket.
@roschaefer
Copy link
Contributor Author

Covered in #218

@roschaefer roschaefer closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants