[WIP] Kafka #9
Open
[WIP] Kafka #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnachen
reviewed
Sep 12, 2017
config/config.go
Outdated
| // Provider defines a set of read-only methods for accessing the application | ||
| // configuration params as defined in one of the config files. | ||
| type Provider interface { | ||
| ConfigFileUsed() string |
There was a problem hiding this comment.
Is there no existing package or library we can use for this? I don't see we're doing any special here.
tnachen
reviewed
Sep 12, 2017
log/log.go
Outdated
|
|
||
| // Logger defines a set of methods for writing application logs. Derived from and | ||
| // inspired by logrus.Entry. | ||
| type Logger interface { |
There was a problem hiding this comment.
What's the purpose of this?
There was a problem hiding this comment.
By having this interface, we would be able to easily change the dependency ( log library ) while we want. If you think this way adds complexity to the code which is not necessary, I can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY / WHAT
To write data to Kafka.