Improve pprinting of stateful examples #4266
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
singleton_printers
does unconditional id-based replacement, which is not always correct (see tests).test_unrelated_rule_does_not_use_var_reference_repr
fails on master with:I think the main use case for the singleton printers is addressed with
VarReference
, and any remaining effects are imo net-negative, though they can sometimes be more readable even if not strictly correct.