Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ultica] Grass clothing #2222

Merged
merged 5 commits into from
Dec 6, 2023
Merged

[Ultica] Grass clothing #2222

merged 5 commits into from
Dec 6, 2023

Conversation

BjoHart
Copy link
Contributor

@BjoHart BjoHart commented Nov 30, 2023

Summary

Grass clothing

Content of the change

Grass clothing, and worn state

Testing

items
worn

Additional information

Fix for myself
#1524

Copy link
Collaborator

@Fris0uman Fris0uman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put new sprites in folder named after contributors, unless your new sprite is an edit of one of the sprites already in that folder, and if so mention it in the pull request

@BjoHart
Copy link
Contributor Author

BjoHart commented Dec 2, 2023

Ok, will start my future sprites with overlay_wield/worn_ and not change json anymore.
Thought that would be the desired way.
Will also create new folders, didn't want to bring more chaos into the whole structure.

@Fris0uman
Copy link
Collaborator

Can you remove the remaining unnecessary json please?

@BjoHart
Copy link
Contributor Author

BjoHart commented Dec 4, 2023

Can you remove the remaining unnecessary json please?

I wanted to leave it that way so that the same sprite is displayed whether you have only grass sheet or grass blanket on.
If that is a problem, i remove the json.

@Fris0uman
Copy link
Collaborator

Ah right, my bad, just edit it put the id that use the same fg together

"id":  ["id_1", "id_2"],
"fg": "fg1"

@Fris0uman Fris0uman merged commit 7816f35 into I-am-Erk:master Dec 6, 2023
3 checks passed
@BjoHart BjoHart deleted the grass-clothing branch December 6, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants