-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create uid2 client side secure signals page #163
Merged
ashleysmithTTD
merged 8 commits into
main
from
ans-UID2-4749-create-uid2-client-side-secure-signals-page
Feb 3, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6567b1a
new uid2 client side sample site
ashleysmithTTD 533b62f
updates on example site to get it working with client side only
ashleysmithTTD fc8c53d
changed to integ credentials
ashleysmithTTD d14cfb0
new workflow file for secure signals client side example
ashleysmithTTD c0a71e6
renamed to client side
ashleysmithTTD 156562b
part of renaming to client side
ashleysmithTTD 57677ff
final testing changes
ashleysmithTTD 884f7b0
added client side to secure signals examples workflow file
ashleysmithTTD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
.github/workflows/release-secure-signals-client-side-uid2.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
name: Release Secure Signal Examples Docker Image for UID2 Client Side | ||
run-name: ${{ inputs.release_type == 'Snapshot' && 'Publish Pre-release' || format('Release {0}', inputs.release_type)}} Secure Signal Examples Docker Image for UID2 Client Side by @${{ github.actor }} | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
release_type: | ||
type: choice | ||
description: The type of release | ||
options: | ||
- Major | ||
- Minor | ||
- Patch | ||
- Snapshot | ||
required: true | ||
|
||
jobs: | ||
incrementVersionNumber: | ||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-increase-version-number.yaml@v2 | ||
with: | ||
release_type: ${{ inputs.release_type }} | ||
working_dir: examples/google-secure-signals-integration/client_side | ||
secrets: inherit | ||
|
||
publishForSecureSignalsExampleClientSide: | ||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-publish-to-docker-versioned.yaml@v3 | ||
needs: incrementVersionNumber | ||
with: | ||
new_version: ${{ needs.incrementVersionNumber.outputs.new_version }} | ||
image_tag: ${{ needs.incrementVersionNumber.outputs.image_tag }} | ||
release_type: ${{ inputs.release_type }} | ||
docker_file: examples/google-secure-signals-integration/client_side/Dockerfile | ||
docker_context: examples/google-secure-signals-integration/client_side | ||
docker_image_name: iabtechlab/uid2-secure-signals-example-client-side | ||
docker_registry: ghcr.io | ||
force_release: no | ||
secrets: inherit |
2 changes: 2 additions & 0 deletions
2
examples/google-secure-signals-integration/client_side/.dockerignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
node_modules | ||
npm-debug.log |
9 changes: 9 additions & 0 deletions
9
examples/google-secure-signals-integration/client_side/Dockerfile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
FROM node:20.11.0-alpine3.18 | ||
|
||
WORKDIR /usr/src/app | ||
|
||
COPY . . | ||
RUN npm install | ||
|
||
EXPOSE 3000 | ||
CMD [ "npm", "start" ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to couple all of these between a release file for each and then a publish file for all three together? Or do we want to make each one a separate publish yml file? This can be done now or later.
Also side note: we should probably rename the "standard" secure signals site to client-server which we can clean up later also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As much as it seems wasteful to have three separate files, I think it makes sense to do that. We won't always be (rarely be?) modifying all of them at once so creating new versions/images with no changes seems bad. what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed