Remove some default styles and replace with classes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: apply `.iati-quote` to existing `blockquote` elements
Having these as default styles was having unexpected consequences for Storybook error messages BREAKING CHANGE: apply `.iati-code` or `.iati-kbd` to existing `code` or `kbd` elements
tillywoodfield
force-pushed
the
remove-defaults
branch
from
fecdcb3 to
349d488
Compare
chrisarridge
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove default styling for a few html elements and give consumers the option to opt-in to them with classes instead, due to a few clashes with Storybook and Sphinx